Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2: Renamed --namespace flag to --namespaces #1098

Merged
merged 1 commit into from
Mar 15, 2020
Merged

v2: Renamed --namespace flag to --namespaces #1098

merged 1 commit into from
Mar 15, 2020

Conversation

vikkyomkar
Copy link
Contributor

What this PR does / why we need it:
This PR renames --namespace flag to --namespaces
Which issue(s) this PR fixes *
Fixes #978

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2020
@olivierlemasle
Copy link
Member

@vikkyomkar CI is failing because of an extra space in cli-arguments.md.
Actually, this file is auto-generated, you can fix it by running make generate.

To fix the issue, you can run:

make generate
git add docs/cli-arguments.md
git commit --amend
git push -f

Thanks!

tariq1890
tariq1890 approved these changes Mar 15, 2020
View reviewed changes
Copy link
Contributor

@tariq1890 tariq1890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tariq1890, vikkyomkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit fdd2ef1 into kubernetes:master Mar 15, 2020
@liangyuanpeng liangyuanpeng mentioned this pull request Feb 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tariq1890 tariq1890 tariq1890 approved these changes

@andyxning andyxning Awaiting requested review from andyxning

@zouyee zouyee Awaiting requested review from zouyee

Assignees

@tariq1890 tariq1890

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2: Rename --namespace flag to --namespaces
4 participants
@vikkyomkar @olivierlemasle @k8s-ci-robot @tariq1890